Add support to specify query params when deleting resources #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bebanjo/bond#1446
What we did
Update lib/almodovar/single_resource.rb in order to allow query param when deleting resources, and with that allow to reload cache or any other related action.
Test cases were updated accordingly
Inspiration
Reviewing the requirements of bebanjo/bond#1446 and doing the less intrusive changes to keep backward-compatibility with previous versions.
Notes for the person doing acceptance
N/A
Functional acceptance
Code Review
How to release this
We need to release two versions of the gem:
master-v1.x
, that works with ruby 2.3master
, that works with ruby 3For 2.0.1:
For 1.8.1:
master-v1.x
master-v1.x
)Warnings
N/A