Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify query params when deleting resources #80

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

AlcidesRC
Copy link

@AlcidesRC AlcidesRC commented Apr 25, 2023

Fixes bebanjo/bond#1446

What we did

Update lib/almodovar/single_resource.rb in order to allow query param when deleting resources, and with that allow to reload cache or any other related action.

Test cases were updated accordingly

Inspiration

Reviewing the requirements of bebanjo/bond#1446 and doing the less intrusive changes to keep backward-compatibility with previous versions.

Notes for the person doing acceptance

N/A

Functional acceptance

  • [✓] Functional tests passed

Code Review

  • [✓] Reviewed preexisting specs changed or deleted (we shouldn't be relaxing the testing criteria or leaving cases uncovered)
  • [✓] Code follows styleguide
  • [✓] Commit messages follow styleguide

How to release this

We need to release two versions of the gem:

  • 1.8.1, based on master-v1.x, that works with ruby 2.3
  • 2.0.1, based on master, that works with ruby 3

For 2.0.1:

  • Merge this PR into master
  • Bump gem version and add to History file
  • Create and push git tag for version 2.0.1
  • Push gem to rubygems
    • gem build almodovar.gemspec
    • gem push almodovar-2.0.1.gem

For 1.8.1:

Warnings

N/A

@littlemove
Copy link
Contributor

@AlcidesRC Updated the issue description so it points, and appear in the UI, to the related Bond issue.

@AlcidesRC
Copy link
Author

PR updated and using Almodovar 2.0.0

@amaia amaia merged commit f995142 into master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants