Fixed remove link so that it works correctly to remove row now. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,6 +72,9 @@ | |||
| if ($(this).text() === "Add") { | |||
| add(); | |||
| } | |||
| if ($(this).text() === "Remove") { | |||
| $(this).parent().parent().parent().parent().remove(); | |||
There was a problem hiding this comment.
Hi, can you make use of "closest" method instead?
|
I amended this commit and force pushed. If you check the diff, it should be correct now. |
brikou
added a commit
that referenced
this pull request
Aug 14, 2011
Fixed remove link so that it works correctly to remove row now.
|
Ok thank |
|
Thank you for showing me a better way of doing things! I've had a minor epiphany about the value of contributing to open source. :) (Little bit new to github) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove link wasn't working. At first I thought this had something to do with Symfony, but after looking at template I realized it was nothing of the sort and we were just missing a little jQuery. Added a couple of lines and now you can remove a pizza from your order you're building.