Skip to content

Commit

Permalink
add return types
Browse files Browse the repository at this point in the history
  • Loading branch information
connorhu committed Feb 9, 2024
1 parent fade1b7 commit f3da722
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions src/Types/PolygonType.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@ class PolygonType extends Type
/**

Check failure on line 16 in src/Types/PolygonType.php

View workflow job for this annotation

GitHub Actions / coding-standards / Coding Standards (8.3)

Useless documentation comment with @inheritdoc.
* {@inheritDoc}
*/
public function getName()
public function getName(): string
{
return self::FIELD;
}

/**
* {@inheritDoc}
*/
public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
{
return 'POLYGON';
}

/**

Check failure on line 32 in src/Types/PolygonType.php

View workflow job for this annotation

GitHub Actions / coding-standards / Coding Standards (8.3)

Useless documentation comment with @inheritdoc.
* {@inheritDoc}
*/
public function canRequireSQLConversion()
public function canRequireSQLConversion(): bool
{
return true;
}
Expand All @@ -42,7 +42,7 @@ public function canRequireSQLConversion()
*
* @return string
*/
public function convertToPHPValue($value, AbstractPlatform $platform)
public function convertToPHPValue($value, AbstractPlatform $platform): string
{
preg_match('/POLYGON\(\((.*)\)\)/', $value, $matches);
if (! isset($matches[1])) {
Expand All @@ -55,23 +55,23 @@ public function convertToPHPValue($value, AbstractPlatform $platform)
/**
* {@inheritDoc}
*/
public function convertToPHPValueSQL($sqlExpr, $platform)
public function convertToPHPValueSQL($sqlExpr, $platform): string
{
return sprintf('AsText(%s)', $sqlExpr);
}

/**
* {@inheritDoc}
*/
public function convertToDatabaseValue($value, AbstractPlatform $platform)
public function convertToDatabaseValue($value, AbstractPlatform $platform): string
{
return sprintf('POLYGON((%s))', $value);
}

/**
* {@inheritDoc}
*/
public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform)
public function convertToDatabaseValueSQL($sqlExpr, AbstractPlatform $platform): string
{
return sprintf('ST_PolygonFromText(%s)', $sqlExpr);
}
Expand Down
6 changes: 3 additions & 3 deletions src/Types/ZendDateType.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ public function getName()
/**
* {@inheritDoc}
*/
public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform): string
{
return $platform->getDateTimeTypeDeclarationSQL($fieldDeclaration);
}

/**
* {@inheritDoc}
*/
public function convertToDatabaseValue($value, AbstractPlatform $platform)
public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string
{
return $value !== null
? $value->toString(Zend_Locale_Format::convertPhpToIsoFormat(
Expand All @@ -56,7 +56,7 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform)
*
* @return Zend_Date
*/
public function convertToPHPValue($value, AbstractPlatform $platform)
public function convertToPHPValue($value, AbstractPlatform $platform): ?Zend_Date
{
if ($value === null) {
return null;
Expand Down

0 comments on commit f3da722

Please sign in to comment.