Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added orm version for test matrix #424

Closed

Conversation

connorhu
Copy link
Contributor

This job config will handle multiple ORM versions later. e.g.:

        orm:
          - 2.7
          - 3.0.0-beta2

@derrabus
Copy link
Collaborator

As I mentioned in #421 (comment), I believe that we don't need a matrix for that just yet. ORM 2 will be tested on the PHP 7 jobs while ORM 3 is covered by the PHP 8 ones.

@connorhu
Copy link
Contributor Author

As I mentioned in #421 (comment), I believe that we don't need a matrix for that just yet. ORM 2 will be tested on the PHP 7 jobs while ORM 3 is covered by the PHP 8 ones.

@derrabus I don't think we're losing anything by testing with ORM2 on php 8, since the main version itself supports it. We can split it into two separate workflow jobs. In PR, the conditions are written to manage where what has to run where.

@SpacePossum
Copy link

Hi,

Could this also cover doctrine/lexer versions ?

I've update a stack to with "beberlei/doctrineextensions": "^1.3" with doctrine/lexer 3 and it breaks:

Error: Cannot use object of type Doctrine\Common\Lexer\Token as array

/app/vendor/beberlei/doctrineextensions/src/Query/Mysql/Cast.php:43
/app/vendor/doctrine/orm/src/Query/Parser.php:3662
/app/vendor/doctrine/orm/src/Query/Parser.php:3526
/app/vendor/doctrine/orm/src/Query/Parser.php:3491

So maybe the project could add "doctrine/lexer": "^2.*" to its composer.json until it supports lexer 3 to prevent end users having to add the lexer version limit to their own composer.json

@connorhu
Copy link
Contributor Author

connorhu commented Feb 5, 2024

In theory, such errors are fixed by PR #410

@derrabus
Copy link
Collaborator

derrabus commented Feb 5, 2024

@derrabus I don't think we're losing anything by testing with ORM2 on php 8

We're losing the simplicity of the current CI workflow. We can revisit this topic after #421, but in order to complete #421, we don't need this matrix.

@connorhu connorhu closed this Feb 5, 2024
@connorhu connorhu deleted the feature/multiple-orm-tests branch February 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants