Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion::url() does not support url with underscores in subdomains #294

Open
mleczakm opened this issue Jan 10, 2020 · 1 comment
Open

Assertion::url() does not support url with underscores in subdomains #294

mleczakm opened this issue Jan 10, 2020 · 1 comment

Comments

@mleczakm
Copy link

Url like this: http://_www.valid-domain.com results in error, when it is perfectly valid.
@rquadling
Copy link
Contributor

The validation in Assertion::url() is based around upon Symfony's UrlValidator which now supports _ in domain names, I will update this to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rquadling @mleczakm