Bugfixes and additions :) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 8, 2011 00:05
- Added: validation to the form/panel. Validates if PHPCS is working and if there are any valid Code Standards. - Added: Validation on preferences storage, avoids invalid settings to be saved. - Added: Refresh button on configuration panel. This button revalidates PHPCS binary and refresh code standards list at users will. - Fixed: NullPointerException if no CodeStandard is selected.
…and if there are any valid Code Standards. - Added: Validation on preferences storage, avoids invalid settings to be saved. - Added: Refresh button on configuration panel. This button revalidates PHPCS binary and refresh code standards list at users will. - Fixed: NullPointerException if no CodeStandard is selected.
|
Can you generate an NPM and send me via mail to kontakt@beberlei.de so i can upload to downloads? I dont use netbeans aynmore :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I tried to pull request like a month ago but, there were an error on Windows support and I preferred not to proceed with the commit.
But, before that, I've had some problems with your plugin (with it not telling why my PHPCS stopped working and so on) and decided to fix it myself and in the middle of hacking I added some stuff that I thought were necessary.
Well, I hope you enjoy those fixes/changes (changelog below), and I'll be glad to help you with anything necessary.
Those changes were tested on NB 7.0+, Ubuntu and Windows.
Best Regards,
Willy.
Changelog: