Bugfixes and additions :) #19

Merged
merged 9 commits into from Jun 18, 2012

Conversation

Projects
None yet
2 participants

Hey guys, I tried to pull request like a month ago but, there were an error on Windows support and I preferred not to proceed with the commit.

But, before that, I've had some problems with your plugin (with it not telling why my PHPCS stopped working and so on) and decided to fix it myself and in the middle of hacking I added some stuff that I thought were necessary.

Well, I hope you enjoy those fixes/changes (changelog below), and I'll be glad to help you with anything necessary.

Those changes were tested on NB 7.0+, Ubuntu and Windows.

Best Regards,
Willy.


Changelog:

  • Added: Shortcut, press Shift+F12 to analyse current file.
  • Added: Validation to the form/panel. Validates if PHPCS is working and if there are any valid Code Standards.
  • Added: Validation on preferences storage, avoids invalid settings to be saved.
  • Added: Refresh button on configuration panel. This button revalidates PHPCS binary and refresh code standards list at user will.
  • Added: Warnings/Errors are also added to the error stripe (column right to the editor scrollbar). Now, one won't need to scroll all the file to find CS warnings/errors.
  • Added: Context menu for JS and CSS files (both also supported by PHPCS tokenizer).
  • Added: Show information dialog if no error/warnings were found.
  • Added: If PHPCS fails with a fatal/parse error, show an information dialog.
  • Fixed: Exception handling if no CodeStandard is selected (NullPointerException).

willybarro added some commits Sep 8, 2011

@willybarro willybarro - Validation Improvements and bugfixes
- Added: validation to the form/panel. Validates if PHPCS is working and if there are any valid Code Standards.
- Added: Validation on preferences storage, avoids invalid settings to be saved.
- Added: Refresh button on configuration panel. This button revalidates PHPCS binary and refresh code standards list at users will.
- Fixed: NullPointerException if no CodeStandard is selected.
db013b2
@willybarro willybarro Changed plugin version to 1.2.1 3b498ed
@willybarro willybarro - Added: validation to the form/panel. Validates if PHPCS is working …
…and if there are any valid Code Standards.

- Added: Validation on preferences storage, avoids invalid settings to be saved.
- Added: Refresh button on configuration panel. This button revalidates PHPCS binary and refresh code standards list at users will.
- Fixed: NullPointerException if no CodeStandard is selected.
368b4b6
@willybarro willybarro - Added: Shortcut for showing Code Standards Violations (Shift + F9) 3ab88c4
@willybarro willybarro Some Bugfixes and additions 9bfa5cc
@willybarro willybarro - Fixed Fatal error handling on Linux. 8a51bb1
@willybarro willybarro README renamed and restyled to the markdown syntax. f0c1379
@willybarro willybarro Readme editing 92fedd1
@willybarro willybarro - Solved bug where NBPreferences were not being persisted. 33e3c8d

@beberlei beberlei added a commit that referenced this pull request Jun 18, 2012

@beberlei beberlei Merge pull request #19 from willybarro/master
Bugfixes and additions :)
ded6cd8

@beberlei beberlei merged commit ded6cd8 into beberlei:master Jun 18, 2012

Owner

beberlei commented Jun 18, 2012

Can you generate an NPM and send me via mail to kontakt@beberlei.de so i can upload to downloads? I dont use netbeans aynmore :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment