Update symfony_integration.md #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fightmaster. The rendering part is entirely untested from my side, so it might fail indeed. I can take a look. The bundle looks great ;) |
beberlei
added a commit
that referenced
this pull request
Jan 29, 2014
Update symfony_integration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Benjamin.
I have pushed PorpaginasBundle. As I understand, porpaginas doesn't work with pagerfanta. There are a some conflicts:
PagerfantaRenderingAdapter.php#L40-L42 and PorpaginasAdapter.php#L12.
Furthermore, there are two undefined classes. https://github.com/beberlei/porpaginas/blob/master/src/Porpaginas/Twig/PagerfantaRenderingAdapter.php#L42
But library and knp_paginator works fine. We have started to use it.