Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerized example #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dockerized example #1

wants to merge 1 commit into from

Conversation

frastel
Copy link

@frastel frastel commented Apr 30, 2016

I thought it would be helpful to dockerize your example. As I am currently working with CoreOS only everything I try needs to run in container.
With this dockerized example every developer could easily start your example without the need to setup some server on his own. I think this changed setup will motivate other developers to try out this example more often.
Due to this refactoring I had to change some things, which breaks your workflow:

  • index.php should be used instead of index.html as the server host is no more static
  • the php webserver is reachable via port 9090. In my case port 8080 is already reserved from the default Docker and Kubernetes setup.
  • websocket is running on port 9191
  • udp server is running on port 9292 and the udp server doesn't listen to localhost anymore. With the dockerized approach this will be no security problem at all because the port is not reachable from outside.

Other stuff is explained in the README.

I am ware of the fact that this breaks a lot for you and that you have to adopt your slides and setup, but I think for other developers would this PR quite helpful.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant