Skip to content

Commit

Permalink
Cloning refactor and data race fix (#393)
Browse files Browse the repository at this point in the history
* enzyme manager to avoid managing global state over the lifetime of a program

* clone_test -> clone to make it easier to test and bench

* remove concurrency

* remove todos

* expose some enzymes

* fix lint

* update changelog and remove pointer reciever.

* moved example test to separate file for namespace clarity in rendered go doc examples.

* renamed variables and added comments.

* renamed variables and removed unnecessary control block.

* added struct field name to changelog.

* Golden Gate is no longer a receiver

* update changelog


---------

Co-authored-by: Timothy Stiles <tim@stiles.io>
  • Loading branch information
TwFlem and TimothyStiles committed Nov 15, 2023
1 parent 58f8699 commit e96a63e
Show file tree
Hide file tree
Showing 4 changed files with 255 additions and 210 deletions.
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- `fastq` parser no longer becomes de-aligned when reading (#325)
- `fastq` now handles optionals correctly (#323)
- No more data race in GoldenGate (#276)

### Breaking
- CutWithEnzymeByName is now a receiver of EnzymeManager. GoldenGate now takes an Enzyme instead of the name of an enzyme.
This is an effort to remove dependence on some package level global state and build some flexibility managing enzymes
over the lifetime of the program.
- Enzyme.OverhangLen is now named Enzyme.OverhangLength

## [0.26.0] - 2023-07-22
Oops, we weren't keeping a changelog before this tag!

[unreleased]: https://github.com/TimothyStiles/poly/compare/v0.26.0...main
[0.26.0]: https://github.com/TimothyStiles/poly/releases/tag/v0.26.0
[0.26.0]: https://github.com/TimothyStiles/poly/releases/tag/v0.26.0
Loading

0 comments on commit e96a63e

Please sign in to comment.