Replaced the Seqhash sequencetype with Struct type argument instead of a plain string.. #264
Conversation
…f a plain string..
|
@TimothyStiles I have a question. Is the vanilla enum implementation sufficient or do I need to convert this into a struct type enum ? |
|
@TimothyStiles can we close this? |
|
@TimothyStiles fix the discord hooks! |
|
Other than that, LGTM. Lots of little linter changes that I'm cool with |
on it now. |
|
@rkrishnasanka can you merge my PR into your local fork? Needs to be done for CI/CD to work. |
|
@TimothyStiles I'm not sure why this is still failing. I merged your PR 😕 |
There was a problem hiding this comment.
@rkrishnasanka this is an excellent PR. Thanks so much for migrating Poly away from ioutil which is being sunset by the official Go team. I'm going to re-add the go linter and merge!
|
No issues ! Let's keep this rolling, let me know if there are other issues you need help on. |
Replaced the sequenceType argument with an Enum.
Currently using the direct const type enum.
Addressing - #264