Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new alignment package and global alignment via Needleman-Wunsch #288

Merged
merged 9 commits into from
Feb 6, 2023

Conversation

TimothyStiles
Copy link
Collaborator

@TimothyStiles TimothyStiles commented Feb 3, 2023

Poly needs a basic alignment algo to compare sequences. Needleman-Wunsch is about as basic as it gets as far as I know and its implementation is only 70 lines or so.

I'm a little unsure of what sort of corner cases I should use to test it and I'm interested to hear if there's a better way to structure calls and pass parameters to align.NeedlemanWunsch. Otherwise everything is clean and code coverage is 100%.

-Tim

@TimothyStiles
Copy link
Collaborator Author

Just added the local alignment algorithm SmithWaterman as well but have yet to implement a traceback to return and it just returns the distance metric score by itself.

@TimothyStiles
Copy link
Collaborator Author

I'm not completely satisfied but this is good enough to ship. Documentation is okay but needs more. I'd like a whole section on alignment algos but they aren't exactly my forte so any guest documentation would be greatly appreciated.

I've moved some SmithWaterman related stuff to two other branches. I somewhat blackboxed getting my implementation to produce the score correctly but am I little lost on how to get the traceback to produce alignments.

Including things like blosum matrices would be a nice update but I don't personally need it now. Would be happy to include if someone makes a PR!

-Tim

@TimothyStiles TimothyStiles merged commit c6cf62a into main Feb 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the align branch February 6, 2023 02:39
TimothyStiles added a commit that referenced this pull request Feb 6, 2023
@TimothyStiles TimothyStiles restored the align branch February 6, 2023 02:41
TimothyStiles added a commit that referenced this pull request Feb 6, 2023
#288)

* initial implementation of global alignment via NeedlemanWunsch

* test coverage 100%

* added wikipedia link for Needleman-Wunsch

* added corner case tests at the suggestion of Daniel Liu @daniel_c0deb0t via twitter
@TimothyStiles TimothyStiles deleted the align branch February 6, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant