Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Io to bio with genbank fixes #394

Merged
merged 22 commits into from
Nov 5, 2023
Merged

Conversation

abondrn
Copy link
Contributor

@abondrn abondrn commented Nov 4, 2023

Changes in this PR

Clearly and concisely summarize the changes you are making. Bullet points are completely okay. Please be specific, saying "improves X" is not enough!

Why are you making these changes?

Explain why these changes are necessary. Link to GitHub issues here with the format fixes: #XXX to indicate this PR resolves the issue.

Are any changes breaking? (IMPORTANT)

Will merging this PR change poly's API in a non-backwards-compatible manner?

Examples of breaking changes:

  • Removing a method from a struct.
  • Deleting/moving a package.
  • Adding a method to an interface (client may have made their own implementation of this interface, and adding a method to the interface could cause client's implementation to no longer satisfy the interface).

Examples of non-breaking changes:

  • Adding a method to a struct.
  • Adding a function.
  • Fixing a bug in a function/method.
  • Creating a new package.

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New packages/exported functions have docstrings.
  • New/changed functionality is thoroughly tested.
  • New/changed functionality has a function giving an example of its usage in the associated test file. See primers/primers_test.go for what this might look like.
  • Changes are documented in CHANGELOG.md in the [Unreleased] section.
  • All code is properly formatted and linted.
  • The PR template is filled out.

Copy link
Contributor

@Koeng101 Koeng101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add to the changelog, and this looks ready to merge!

@abondrn abondrn mentioned this pull request Nov 5, 2023
6 tasks
@Koeng101 Koeng101 merged commit 35a5492 into bebop:ioToBio Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants