Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where linear, non-directional, single cuts were copying and not just moving overhangs from the fragment sequence. #409

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

TimothyStiles
Copy link
Collaborator

Changes in this PR

Clearly and concisely summarize the changes you are making. Bullet points are completely okay. Please be specific, saying "improves X" is not enough!
Fixed bug where linear, non-directional, single cuts were copying and not just moving overhangs from the fragment sequence.

Why are you making these changes?

Otherwise this leaves the overhangs as part of the fragment sequence which can cause further downstream errors.

Are any changes breaking? (IMPORTANT)

NO

Pre-merge checklist

All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.

  • New/changed functionality is thoroughly tested.
  • All code is properly formatted and linted.
  • The PR template is filled out.

… not just moving overhangs from the fragment sequence.
@TimothyStiles TimothyStiles merged commit f76bf05 into main Dec 1, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the single-cut-not-removing-overhangs-regression branch December 1, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant