Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with jquery #18

Closed
charlieblevins opened this issue Feb 22, 2014 · 4 comments
Closed

conflict with jquery #18

charlieblevins opened this issue Feb 22, 2014 · 4 comments

Comments

@charlieblevins
Copy link

Hey bebraw!
I love color joe and really appreciate your work! It's a beautiful plugin.
I just wanted to make you aware that colorjoe does not initialize on any page that also has jquery. I've tested this by including jquery in the supplied demo files. I haven't had time to look into why this breaks colorjoe so I apologize for not offering more info. If I am missing something please feel free to correct me.

I'm really looking forward to using the plugin if this is a solve-able issue. Thank you for your hard work!

@bebraw
Copy link
Owner

bebraw commented Feb 22, 2014

Thanks for letting me know! I'll look into it.

@bebraw
Copy link
Owner

bebraw commented Feb 22, 2014

Hi,

I traced down the issue. It looks like one.color installs itself to $.color if jQuery exists. colorjoe expects to find it at window.one.color.

I could try to detect this case on my side but that feels a bit strange. I'll open an issue at one.color to see what their thoughts are on the issue.

@charlieblevins
Copy link
Author

Cool! Thanks for checking into it. Looking forward to seeing what happens.

On Sat, Feb 22, 2014 at 7:36 AM, Juho Vepsäläinen
notifications@github.comwrote:

Hi,

I traced down the issue. It looks like one.color installs itself to
$.color if jQuery exists. colorjoe expects to find it at window.one.color.

I could try to detect this case on my side but that feels a bit strange.
I'll open an issue at one.color to see what their thoughts are on the issue.

Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-35801595
.

Thanks,
Charlie Blevins
423 762 8810

@bebraw
Copy link
Owner

bebraw commented Feb 22, 2014

@charlieblevins The issue should be resolved now. Try updating one-color and giving it a go.

@bebraw bebraw closed this as completed Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants