Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex et RGB color #33

Open
simetin opened this issue Nov 14, 2015 · 8 comments
Open

Hex et RGB color #33

simetin opened this issue Nov 14, 2015 · 8 comments

Comments

@simetin
Copy link

simetin commented Nov 14, 2015

Hi !
I got 2 problems when I try to manually enter a color. First, in the RGB field my cursor keep coming back to the end, I need to remplace it 2 times to be able to enter a color.
Second, in the Hex field when I enter the color there is a modification in the hex value and when I press close, it change to black.
Am I the only one with these problems ?

Your color picker is really great, so if I could get those two things to work, everything would be perfect !

Thanks !

@bebraw
Copy link
Owner

bebraw commented Nov 15, 2015

Can you try modifying hex extra? Here's rgb. Maybe there's some corner case missing.

@simetin
Copy link
Author

simetin commented Nov 15, 2015

I can try to take a look, but I really don't think that I'm skilled enough for that

@bebraw
Copy link
Owner

bebraw commented Nov 30, 2015

@tchinou1 Any luck? Do you want me to have a look? If you can set up a standalone test case for me to study, that will help.

@simetin
Copy link
Author

simetin commented Dec 1, 2015

No I haven't been able to do anything. If you want to check, it would be very nice ! But I'm not sure to understand what you mean by a standalone test case.
Thanks !

@bebraw
Copy link
Owner

bebraw commented Dec 1, 2015

@tchinou1 Just something to illustrate the issue. Do you see it at the online demo?

@simetin
Copy link
Author

simetin commented Dec 1, 2015

No, here is a page of my app: http://luxontower.com/app/colorpickerdemo.php

@bebraw
Copy link
Owner

bebraw commented Dec 3, 2015

I got 2 problems when I try to manually enter a color. First, in the RGB field my cursor keep coming back to the end, I need to remplace it 2 times to be able to enter a color.

Confirmed. I think the hex input will need a little tweak to retain its position. It's going to get a little complicated depending on which browsers we want to support. Here's the basic idea: https://stackoverflow.com/questions/2897155/get-cursor-position-in-characters-within-a-text-input-field .

Second, in the Hex field when I enter the color there is a modification in the hex value and when I press close, it change to black.

This is a weird one. I cannot see the behavior in the official demo. Can you try to figure out how your setup differs from that? It looks like the value cycles (00000b -> 0000b0).

@bebraw
Copy link
Owner

bebraw commented Dec 3, 2015

Third issue: Before opening the selector, we should probably do a cropping check against the window. I mean we should open at top of the input if it's going to crop. Otherwise it's going to be unusable for those lower inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants