Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Use PUT request for set* calls, added create* calls for POST requests #5

Merged
merged 2 commits into from
Apr 1, 2015

Conversation

lwille
Copy link
Contributor

@lwille lwille commented Mar 31, 2015

using setChecks to modify existing checks is failing because POST is used instead of PUT.

This merge request changes the method for set* calls to PUT and adds create* calls to use POST method.

@bebraw
Copy link
Owner

bebraw commented Mar 31, 2015

Nice! Do you have some other changes coming up? I'll coordinate a release with your changes once you are ok with it. :)

@lwille
Copy link
Contributor Author

lwille commented Mar 31, 2015

Thanks for the speedy reply :)

That's all I have for now. I'm using this module to keep my Check's auth cookies fresh :D

If the current interface shouldn't be broken, I'd suggest to leave the set calls with POST and add an update* call for PUT.

@bebraw
Copy link
Owner

bebraw commented Mar 31, 2015

Good point.

Let's break the interface and document it. I'll bump the version to 0.6.0 so semver stays ok. Might as well go to 1.0.0 given the library should be quite complete.

Would you mind adding yourself to project contributors at README?

@lwille
Copy link
Contributor Author

lwille commented Mar 31, 2015

well, then we could even rename set to update - so we end up with more intuitive CRUD-like method names. I guess nobody really wants DELETE :-)?

@bebraw
Copy link
Owner

bebraw commented Mar 31, 2015

well, then we could even rename set to update - so we end up with more CRUD names. I guess nobody really wants DELETE?

Yeah, update is better.

If DELETE is supported by their API (can't remember), it could be nice to add.

bebraw added a commit that referenced this pull request Apr 1, 2015
Use PUT request for set* calls, added create* calls for POST requests
@bebraw bebraw merged commit 1b79571 into bebraw:master Apr 1, 2015
@lwille
Copy link
Contributor Author

lwille commented Apr 1, 2015

Okay, then let's add it

@bebraw
Copy link
Owner

bebraw commented Apr 1, 2015

Alright, I'll set up something (no guarantees it will work) to try out. :)

@lwille
Copy link
Contributor Author

lwille commented Apr 1, 2015

Thanks for merging; updateChecks is working like a charm.

@bebraw
Copy link
Owner

bebraw commented Apr 1, 2015

Ok, great. A stable 0.6.0 is out now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants