Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Language to Descriptor #94

Closed
wants to merge 1 commit into from

Conversation

ChakshuGautam
Copy link

@ChakshuGautam ChakshuGautam commented Dec 15, 2022

@emmayank
Copy link
Collaborator

emmayank commented Nov 3, 2023

Hi @ChakshuGautam ,

Thank you for your pull request. We appreciate your effort and time in submitting this request. However, we have a few suggestions to ensure the alignment with our guidelines and protocols:

  1. Please raise the pull request to the draft branch instead of the Master branch to streamline our workflow and facilitate effective review processes.
  2. If any changes are required in the Core Beckn Schema, we recommend raising a pull request with the core protocol-specification repository. This will ensure that the changes are properly integrated and aligned with the overall protocol.
  3. According to the Beckn Specification, a descriptor represents a physical description of something. Adding language to the descriptor may not add significant value to the definition. You can utilize tags to define languages for the course, which aligns with the established specifications.

Your understanding and attention to these suggestions are highly appreciated. If you have any questions or need further clarification, please don’t hesitate to reach out. We are here to assist you through this process.

Thank you once again for your contribution.

Best regards,
Mayank Bansal

@emmayank
Copy link
Collaborator

Hi @ChakshuGautam ,

I hope this message finds you well. 👋

We noticed that there hasn't been any activity on your pull request #94 for the past two weeks, specifically regarding the comment we left. We value your contribution, and we understand that life gets busy. If you have any further questions or would like to continue the discussion, please feel free to reopen the pull request or create a new one. We appreciate your efforts and would love to see your contributions in the future.

Thank you for your understanding.
Best regards,
Mayank Bansal

@emmayank emmayank closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants