Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell sort #3

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Shell sort #3

merged 6 commits into from
Nov 4, 2019

Conversation

underhood31
Copy link
Contributor

Added new sorting algorithm: shell-sort.

@becurrie becurrie self-requested a review November 2, 2019 16:55
becurrie
becurrie requested changes Nov 2, 2019
View reviewed changes
Copy link
Owner

@becurrie becurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Great addition of a new sort method, just some tiny syntactical changes and I'd be happy to merge! 👍

README.md Show resolved Hide resolved
py_sorter/sorter.py Outdated Show resolved Hide resolved
py_sorter/sorter.py Outdated Show resolved Hide resolved
py_sorter/sorter.py Outdated Show resolved Hide resolved
py_sorter/sorts.py Outdated Show resolved Hide resolved
@becurrie becurrie self-assigned this Nov 2, 2019
@becurrie becurrie added algorithm enhancement New feature or request labels Nov 2, 2019
underhood31 and others added 4 commits November 4, 2019 12:57
@underhood31 @becurrie
Update py_sorter/sorter.py
13cb817 
Co-Authored-By: votum <24272608+becurrie@users.noreply.github.com>
@underhood31 @becurrie
Update py_sorter/sorter.py
94c8f37 
Co-Authored-By: votum <24272608+becurrie@users.noreply.github.com>
@underhood31 @becurrie
Update py_sorter/sorts.py
9823906 
Co-Authored-By: votum <24272608+becurrie@users.noreply.github.com>
@underhood31 @becurrie
Update py_sorter/sorter.py
e977929 
Co-Authored-By: votum <24272608+becurrie@users.noreply.github.com>
becurrie
becurrie approved these changes Nov 4, 2019
View reviewed changes
Copy link
Owner

@becurrie becurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, approving 👍

@becurrie becurrie merged commit 8d5894a into becurrie:master Nov 4, 2019
@becurrie becurrie mentioned this pull request Nov 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becurrie becurrie becurrie approved these changes

Assignees

@becurrie becurrie

Labels
algorithm enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@underhood31 @becurrie