Extract resolveDataResults function. Add test
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruscoder
reviewed
Jan 30, 2020
ruscoder
reviewed
Jan 30, 2020
| @@ -52,22 +52,57 @@ export function mapFailure<S = any, F = any, R = any>( | |||
| } | |||
|
|
|||
| export type PromiseRemoteDataResultMap<T, F> = { [P in keyof T]: Promise<RemoteDataResult<T[P], F>> }; | |||
| export type RemoteDataResultMap<T, F> = { [P in keyof T]: RemoteDataResult<T[P], F> }; | |||
|
|
|||
| function createKeysMapTransformer<K = any>(keys: Array<K>) { | |||
There was a problem hiding this comment.
As we use lodash, let's simplify it with return (values) => _.fromPairs(_.zip(keys, values))
There was a problem hiding this comment.
I plan to get rid of lodash
ir4y
force-pushed
the
5-refactoring-resolveServiceMap
branch
2 times, most recently
from
0edeec5
to
86d8ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.