Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiplate wrapper iterate only on current plate scores #32

Open
julianesiebourg opened this issue Nov 13, 2023 · 1 comment · May be fixed by #33
Open

multiplate wrapper iterate only on current plate scores #32

julianesiebourg opened this issue Nov 13, 2023 · 1 comment · May be fixed by #33
Assignees

Comments

@julianesiebourg
Copy link
Collaborator

line 49 and following

    for (curr_plate in plate_levels) {
      if (!quiet && length(plate_levels) > 1) cat(curr_plate, "... ")

      bc <- optimize_design(bc,
        scoring = scoring_funcs,              # TODO: Here we should just use the scores of the current plate
        max_iter = max_iter,
        quiet = TRUE,
        shuffle_proposal_func = mk_subgroup_shuffling_function(
          subgroup_vars = plate,
          restrain_on_subgroup_levels = curr_plate
        ),
        acceptance_func = accept_leftmost_improvement
      )
    }
@julianesiebourg
Copy link
Collaborator Author

maybe remove the unlist() from line 38 to get a list of lists
and then extract the curr_plate for all factors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants