Ignore attributes when they contain arrays #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might be an issue regarding array'ed values, but your patch effectively stops anything from being logged at all.. Both will always be arrays as they contain a list of attributes and their values. |
|
Oh dammit. I will rework this, thanks for being that attentive. |
|
@Blizzke Just a kind reminder that this issue is still open. I am using the great yii2-audit module in an project and would dislike to do an own fork just because of this small change. Thanks a lot :) |
|
He seems to be afk for a while.
Please change your solution to Json::encode if it's an array.
Apart from that it looks good, happy to pull it in.
…On 1 Mar 2017 11:07 pm, "Herbert Maschke" ***@***.***> wrote:
@Blizzke <https://github.com/Blizzke> Just a kind reminder that this
issue is still open. I am using the great yii2-audit module in an project
and would dislike to do an own fork just because of this small change.
Thanks a lot :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADKo-7HfPR3E7-vfxuscMrdHMLCfy0cks5rhWaGgaJpZM4LsEQ_>
.
|
thyseus
force-pushed
the
ignore-arrays-as-attributes
branch
from
6010334
to
54ceb5f
Compare
|
@cornernote any progress with this issue? any chance to get this into the next release? thanks |
|
I can't seem to see a link to a pull request. Let me know what it is and
ill have a look
…On 5 Apr 2017 7:41 pm, "Herbert Maschke" ***@***.***> wrote:
@cornernote <https://github.com/cornernote> any progress with this issue?
any chance to get this into the next release? thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADKo3S2tE8TJMNQOsVAYDLoxzfiNhtZks5rs2jigaJpZM4LsEQ_>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an small workaround to avoid this error when using arrays as attribute values (which should be serialized somehow before saving and unserialized in afterFind()):
We should consider supporting this case properly in an future yii2-audit version.