Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate input data in bedita setup shell script #1013

Open
batopa opened this issue Oct 13, 2016 · 1 comment
Open

Validate input data in bedita setup shell script #1013

batopa opened this issue Oct 13, 2016 · 1 comment
Labels
Priority - Low Topic - Core Type - Enhancement
Milestone
4-next

Comments

@batopa
Copy link
Member

batopa commented Oct 13, 2016

To mitigate potential risks in bedita setup script when writing database connection data in config/app.php we should validate the user input data.

Using the Cake\Filesystem\File class also helps writing file more safely.

See #1005 (review)
@batopa batopa added this to the 4-next milestone Oct 13, 2016
@stefanorosanelli stefanorosanelli modified the milestones: 4.0.0-alpha2, 4-next Feb 3, 2017
@stefanorosanelli stefanorosanelli modified the milestones: 4.0.0-alpha2, 4-next Aug 30, 2017
@fquffio
Copy link
Member

fquffio commented Nov 7, 2017

This issue should now be obsolete, after #1371.

@stefanorosanelli @batopa Shall we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority - Low Topic - Core Type - Enhancement
Projects
None yet
Milestone
4-next
Development

No branches or pull requests
3 participants
@batopa @stefanorosanelli @fquffio