Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web installer #137

Closed
stefanorosanelli opened this issue Sep 5, 2012 · 23 comments
Closed

web installer #137

stefanorosanelli opened this issue Sep 5, 2012 · 23 comments

Comments

@stefanorosanelli
Copy link
Member

design an installer with Web interface, reusing ideas and code from init shell script

BeditaShell::init()
@ghost ghost assigned didoda Sep 5, 2012
@stefanorosanelli
Copy link
Member Author

dare un occhio all'installer wordpress, molto semplice....

@stefanorosanelli
Copy link
Member Author

dante:

  • progettazione/proposta di web installer molto semplice, usando come riferimento wordpress/drupal
  • niente codice, per ora, descrivi funzionamento e eventuali problematiche

@didoda
Copy link
Member

didoda commented Sep 5, 2012

Ho rilasciato una parte del wizard. 25967bd
Per provarlo, decommentate le righe in /index.php relative al wizard, che seguono // commento temporaneamente - wizard DA ULTIMARE

Ho lavorato sulle 2 prime parti (controlli permessi su filesystem, cartelle di smarty e di cake) + impostazione connessione a database.

Ho usato smarty per gestire le template.
In futuro possiamo pensare di fare il tutto con un controller di bedita, ma al momento era molto problematico poter gestire un controller senza avere il database funzionante.

Conto di poter finire l'ultima parte (admin user + impostazione mediaroot,mediaurl,modrewrite) la prossima settimana.

@didoda
Copy link
Member

didoda commented Sep 5, 2012

efb7414 Rilascio del corpus principale del wizard.
Per provarlo, fare un diff di webroot/index.php con webroot/index.php.sample e copiare il blocco di codice relativo al wizard su index.php.

@stefanorosanelli
Copy link
Member Author

fatta prova su windows, funziona!

  • non ho visto come si comporta sui permessi su filesystem in caso di errore
  • quando ha caricato dati/schema su db non ho visto un feedback tipo "dati caricati"

cmq l'impostazione generale va bene direi

NB: per fare test consiglio di creare paccehtti di realease, "cake.sh deploy release" e lavorare su quelli

@didoda
Copy link
Member

didoda commented Sep 5, 2012

Ho fatto anche io una prova con windows. Installazione su windows xp, con browser Opera 10.63.
Ha funzionato senza nessun problema.

Confermo che manca un feedback dopo aver caricato i dati di init del db.
Lavoro su quello.

@didoda
Copy link
Member

didoda commented Sep 5, 2012

0080c08 ho aggiunto feedback su initdb. Ho rifatto un tar di release e testato nuovamente su windows xp, questa volta con Internet Explorer 8. Andato tutto lisco.

@stefanorosanelli
Copy link
Member Author

problema su http://test.bedita.com/

dopo la pagina di connessione al db ottengo

Fatal error: Call to undefined function apache_get_modules() in /var/www/test.bedita.com/setup/setup.php on line 285

la funzione non e' necessariamente presente, fare un ckeck se esiste - se non c'e' altro modo di capire automaticamente se mod_rewrite abilitato chidere all'utente

@didoda
Copy link
Member

didoda commented Sep 5, 2012

1f9c278 inserito il controllo sulla presenza di apache_get_modules...

@batopa
Copy link
Member

batopa commented Sep 5, 2012

Provare ad inserire il css di BEdita a vedere che salta fuori

@stefanorosanelli
Copy link
Member Author

7c91a80
Some important changes

  • BE config file is now only bedita.cfg.php (.sys deprecated), changes/consequences also in admin/config admin: configuration page #268
  • if this file is missing (bedita.cfg.php) setup wizard starts
  • install requirements: /tmp /config /webroot/files must be writable by webserver
  • wizard steps are: 'Filesystem', 'Database', 'Admin User' - at the end bedita.cfg.php will be created and a new 'beditaUrl' is set, taken from current URL
  • 'Filesystem' step: only error messages are shown (if any)

Internals:

  • everything (php,css,tpl) is in /setup
  • css/setup.css is included inside every html/tpl page
  • filesys.html is used in first step view (smarty could be unavailable), other steps are in .tpl

@stefanorosanelli
Copy link
Member Author

Remaining issues:

  • not working for postgres - installer hangs in "init Db schema & data", db is set up and populated, button "Next" is not active .. ??
  • user message / feedback when changing schema/data: "please wait, this operation may take a while.... " - disable button while processing
  • remove "port 3306" and "mysql_connect" from advanced properties in db setup (not valid for postgres)

@stefanorosanelli
Copy link
Member Author

and:

  • restore mod_rewrite presence control with modified settings in core.php (with user message)

@stefanorosanelli
Copy link
Member Author

(In 922f4a8) installer: fix postgres issues, mod_rewrite check and confi restored - see #137

@stefanorosanelli
Copy link
Member Author

  • postgres installer now working
  • all issues fixed except user message when changing schema data

test, test, test ... then close!

@nikazzio
Copy link
Member

nikazzio commented Sep 5, 2012

(In 9ce30a7) refs #137

@nikazzio
Copy link
Member

nikazzio commented Sep 5, 2012

Replying to [comment:19 niki]:

(In 9ce30a7) refs #137

system tested and working:

ubuntu 12.04 + mysql 5.5.24 + firefox
ubuntu 12.04 + postgres 9.1 + firefox
windows xp + XAMPP + iExplorer 8
windows xp + XAMPP + chrome

Fixing some issues:

  • "Finish" page now work correctly, with the blue color on the menu and page_finish() write "beditaUrl" on the bedita.cfg.php correctly
  • On Admin page changed error level for ulr checking to WARN instead of ERROR
  • submitting the Admin page by pressing "Enter" key now work correctly

@batopa
Copy link
Member

batopa commented Sep 10, 2012

I found an issue trying to install BEdita from dev code that I haven't encountered in the last package (beta2).
I created a new test package and the error is present.

There has been a regression in one of last commit

All the process runs smoothly but the admin user is not created, the default "bedita" user remains active and no error is thrown.

To test it:

git clone https://github.com/bedita/bedita.git

then launch the installer from the browser.

stefanorosanelli added a commit that referenced this issue Sep 18, 2012
…ter), display mod_rewrite message only on error - see #137
@stefanorosanelli
Copy link
Member Author

removed wrong bedita url/media url/media root info - calculated in next step
mod_rewrite message only on configuration error/problem
to close: create reference in docs.bedita related to mod_rewrite issues in bedita/cake -- add a link in setup if something's wrong with mod_rewrite - @didoda @batopa : what do you think?

@didoda
Copy link
Member

didoda commented Sep 19, 2012

I agree. It's a not uncommon case: install from wizard, mod_rewrite disabled... => good idea suggesting steps (in a doc in docs.bedita I'd describe more details about it). I prepared already 2 screencasts of "install BEdita using wizard" (mod_rewrite on and mod_rewrite off videos). Soon on bedita-youtube channel...

@batopa
Copy link
Member

batopa commented Sep 19, 2012

I agree too. Most apache configurations come with mod_rewrite disabled by default.
I agree also to add a mod_rewrite document on docs.bedita.com and to show a link to it in setup if mod_rewrite is disabled.

I suggest also:

Done it we can close this generic issue and in case open specific bugs/features issues.

@didoda
Copy link
Member

didoda commented Sep 21, 2012

@stefanorosanelli
Copy link
Member Author

Added link to article in BEdita installer if mod_rewrite is not enabled.
Installer UI should be much more cool :-) - we'll see this in another ticket
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants