Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug. Category name change when changing category label #403

Closed
qwerg opened this issue Nov 27, 2013 · 4 comments
Closed

Bug. Category name change when changing category label #403

qwerg opened this issue Nov 27, 2013 · 4 comments

Comments

@qwerg
Copy link
Member

qwerg commented Nov 27, 2013

When you change the label of an already made BEdita category, the category name is also modified. However the category name should be stable, as a uniquename.
Maybe we could also manage both fields (name and label) in the backend category management view.

@ghost ghost assigned batopa Nov 27, 2013
@batopa
Copy link
Member

batopa commented Nov 27, 2013

The category name would be editable only by administrators.

@batopa
Copy link
Member

batopa commented Nov 28, 2013

I have two doubts:

  1. what we should do in this case. A category was created in a specific module with label category test and the name generated was category-test. Then the label is changed in category test it. The name remains category-test.
    In the same module a new category with the same label category test it is created. Since the name generated automatically is category-test-it the entry is ok but then we have two categories with the same label on the same module. What should we do? Avoid label duplication?
  2. what about tags? Tags are handled by the same Category model. Changing tag label should change also unique name or it should behave as category?

@qwerg qwerg closed this as completed Nov 29, 2013
@qwerg qwerg reopened this Nov 29, 2013
@batopa
Copy link
Member

batopa commented Nov 29, 2013

Talking with @qwerg we decided to proceed in the following way:

  1. No check on category labels. The category name will be visible in readonly mode for all users. Only administrators could change it.
  2. Tags behaves exactly as category. The tag name will be visible in readonly mode for all users. Only administrators could change it.

batopa added a commit that referenced this issue Dec 2, 2013
@batopa
Copy link
Member

batopa commented Dec 2, 2013

Implemented
@qwerg test it then if you could adjust the style in manage categories. The tab where to add new category is now shorter then the rows of the table above due to the addition of the unique name column

@qwerg qwerg closed this as completed Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants