Mislabeled blocks

[picotazo]

OK looking closer at the XML file and using my test world I am seeing many mislabeled using the original XML file. When I am using the updated XML file from my fork many missing blocks now show in the output but are still mislabeled or just don't appear if I have 1 of each slab on the ground, for example the 3 different prismarine slabs are labeled as "slab, Red Sandstone" and newer blocks like " "Cut red sandstone" and "cut sandstone" don't show up at all. Looking at the XML it seems like it has something to do with the blocks that have block variants, like the program is ignoring the variants and only being identified as the root block.

Another example possibly the easiest to view is wood planks all are labeled as oak planks.

On the other hand some of the new items such as the new wooden buttons/doors/trapdoors since they are all individual Blocks they all are identified properly.

I tired removing the main color of the item and adding the different colors for the variants they then get labeled as "UNKNOWN BLOCK"

[picotazo]

OK all stone blocks are all being identified as basic "stone" not diorite or granite or anything. Either the program is ignoring the DV/blockdata piece when it identifies the block or it needs to be changed to look at the "stone_type" tag to determine its type. I think the same thing goes for most other blocks that have variants, like the wood,slabs and stairs do not know where in the program this is determined.

[counterfitninja]

Looks like concrete is doing the same thing. Ill take a look at the code and see if i can find anything but so far it all looks ok. Like you say its seems to be ignoring the blockdata

[picotazo]

Cool thank you for taking a look at it.. Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

…

________________________________ From: counterfitninja <notifications@github.com> Sent: Monday, April 13, 2020 3:25:56 AM To: bedrock-viz/bedrock-viz <bedrock-viz@noreply.github.com> Cc: Picotazo <peck_13@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [bedrock-viz/bedrock-viz] Mislabeled blocks (#20) Looks like concrete is doing the same thing. Ill take a look at the code and see if i can find anything but so far it all looks ok. Like you say its seems to be ignoring the blockdata — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbedrock-viz%2Fbedrock-viz%2Fissues%2F20%23issuecomment-612844092&data=02%7C01%7C%7C15446dc8b2ae4be9958208d7df950d8c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637223703570485862&sdata=NUOsAvBH9Uf9SgdmdfhnBHRFq%2FbQzThbhFMH0Zz6qWY%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIBKZPOZGSXC3E4F6JIFDI3RMLSDJANCNFSM4LHF2DDA&data=02%7C01%7C%7C15446dc8b2ae4be9958208d7df950d8c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637223703570485862&sdata=9BiiPmrOxsr5OQ%2FhfAjhY3zsBgbHzsrPEupaR04aWu4%3D&reserved=0>.

[counterfitninja]

I dont think any of the block variants are working. It seems to be pick this first in the list and lable them all with that. Ill do some more digging.