Picotazo patch 2 Massive update to xml file

[picotazo]

No description provided.

[paulgrahek]

The files changes you uploaded were committed to the root of the repository, not to the location where the files were at before. See below where the files should be:
mcpe_viz.cfg -> data/mcpe_viz.cfg
mcpe_viz.xml -> data/mcpe_viz.xml
mcpe_viz.html.template -> static/mcpe_viz.html.template
Feel free to email me if you need any help, this is a pretty big update. Thank you

[tomnolan]

@paulgrahek I think there was a comment in the issue thread from @picotazo that they put it into the root folder to have it be used by the app when it executes since the data folder isn't searched by the app. I believe that is intentional, correct?

[paulgrahek]

@tomnolan good catch. When this repo was forked some of the configuration files were moved when the project was restructured, but it does not appear the code was updated to look for the configuration file in the new data folder. Currently the folder looks in the command line, the home directory (is this one necessary?), and then the local folder of the application.
The build configuration does copy the gui and data folders into the build directory, so it appears the new intended behavior is to look for the configuration file in the data folder.
@jasper-wan what do you think?

[scp-r]

@paulgrahek you are right, there is a bug in load_cfg function and we need to add <install-prefix>/data/mcpe_viz.cfg to the search location of cfg file. Since users can not change files in /usr/local/share, the cfg in this folder may be treated as a default configuration if no configuration file is found.
New files in root directory of the project won't work unless you modify CMakeLists.txt to process it . Currently, cmake will copy specific files to destination folder after building the program:

# the data folder
file(COPY data
     DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
# the static folder
file(COPY static
        DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
# we dont need to `make install` on Windows
install(TARGETS bedrock-viz DESTINATION bin) # program itself
install(DIRECTORY data/ DESTINATION share/bedrock-viz/data) # data
install(DIRECTORY static/ DESTINATION share/bedrock-viz/static) # static 

[tomnolan]

I ran through this xml file last night and there are a bunch of edits needed to make it work. I'm going to make an update for this PR this weekend with those sites and I'm trying to get some of the new nether update blocks included as well. Then we should be able to merge this one as well.

[picotazo]

I looked through it last night and found I had a bunch of Block ID's that were all off by a digit. Sorry about that.

[tomnolan]

@picotazo I'm going to close this PR since it no longer applies. Thank you for getting the XML for this started though, I made sure to mention you in the changelog :-)

[picotazo]

I saw that thank you very much.. I was just about to add another issue once I verify my findings I grabbed the release v0.1.2 to use as a base starting point. Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10 From: Tom Nolan<mailto:notifications@github.com> Sent: Monday, June 29, 2020 6:21 AM To: bedrock-viz/bedrock-viz<mailto:bedrock-viz@noreply.github.com> Cc: Picotazo<mailto:peck_13@hotmail.com>; Mention<mailto:mention@noreply.github.com> Subject: Re: [bedrock-viz/bedrock-viz] Picotazo patch 2 Massive update to xml file (#17) @picotazo<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpicotazo&data=02%7C01%7C%7C98f7dc97da834e158e9308d81c2f6319%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637290337131823732&sdata=%2BhvZFGsxOPlBT%2FS%2BaaVWh7NReFwEXpJ%2BLRFrkasqi24%3D&reserved=0> I'm going to close this PR since it no longer applies. Thank you for getting the XML for this started though, I made sure to mention you in the changelog :-) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbedrock-viz%2Fbedrock-viz%2Fpull%2F17%23issuecomment-651116760&data=02%7C01%7C%7C98f7dc97da834e158e9308d81c2f6319%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637290337131833723&sdata=eiWvEJgfKUwKZArjFhkDmoGa9B2WRWGXAtnhDX5XzMc%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIBKZPL432KFEQI6O4PMCR3RZCIO7ANCNFSM4LDE5NLQ&data=02%7C01%7C%7C98f7dc97da834e158e9308d81c2f6319%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637290337131843721&sdata=%2FSz%2FgdGND2gZYYTDNeiWDAxNCUtT8W6HLIdfRmUOLss%3D&reserved=0>.