Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove placeholder if it's not going to be used #48

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

cabbey
Copy link
Member

@cabbey cabbey commented Jul 8, 2020

building with --no-force-geojson currently leaves %JSFILE% in the generated index.html, which then renders in the browser and kills an entire text line worth of height on the display.

image

(note not sure this is the best solution, I just aped the code that was in the if leg to replace it with nothing and it works.)

building with `--no-force-geojson` currently leaves `%JSFILE%` in the generated index.html, which then renders in the browser.
@paulgrahek paulgrahek requested a review from tomnolan July 8, 2020 17:13
@cabbey
Copy link
Member Author

cabbey commented Jul 8, 2020

An alternate approach might have been to make the placeholder a valid html comment and replaced the whole thing, something like <!-- %JSFILE% -->, this way in the case where it's not replaced, it isn't renderable content. (I didn't think of that at 2am when I was trying to make a map to show my son today. ;)

@paulgrahek paulgrahek added the font-end Issues that deal with the HTML front-end in some way label Jul 8, 2020
@tomnolan
Copy link
Member

An alternate approach might have been to make the placeholder a valid html comment and replaced the whole thing, something like <!-- %JSFILE% -->, this way in the case where it's not replaced, it isn't renderable content. (I didn't think of that at 2am when I was trying to make a map to show my son today. ;)

You're right on with this @cabbey, but as my wife says, it's six in one and a half dozen in the other. Thanks for contributing.

PR looks good to me!

@tomnolan
Copy link
Member

Resolves #49

@cabbey
Copy link
Member Author

cabbey commented Jul 13, 2020

Ah, as a project you require an issue for all PRs? I'll keep that in mind for the future.

@paulgrahek paulgrahek merged commit 6b2bf9d into bedrock-viz:master Jul 17, 2020
@cabbey cabbey deleted the remove-placeholder branch December 22, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
font-end Issues that deal with the HTML front-end in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants