Cleanup #231
Cleanup #231
Conversation
beatlevic
commented
Mar 6, 2023
beatlevic
commented
- Making ingresses the default of loadBalancers for api and web
- Separate github workflows for web and api
- Removed unused volume mounts
- Removed githooks
- removed empty .env
- removed top .dockerignore and expanded the ignores in web and api
| @@ -9,8 +9,9 @@ | |||
| "nodePoolCount": 2, | |||
| "minNodeCount": 2, | |||
| "maxNodeCount": 4, | |||
| "machineType": "n2-standard-2" | |||
| "machineType": "n2d-standard-2" | |||
There was a problem hiding this comment.
Is n2d supposed to provide better performance?
There was a problem hiding this comment.
It is roughly the same, but cheaper
There was a problem hiding this comment.
This looks good to me. Since you're thinking about this now, you would be an absolute legend if you could also make it possible (and if it's not a huge lift) to choose the instance type when creating a new project (n2, e2, micro etc)...
I'll look into this one, but the list of possible instance types is huge. Before you bootstrap, you can always update the config.json manually :)
There was a problem hiding this comment.
but cheaper
Love that part!
but the list of possible instance types is huge
I don't need an exhaustive list... in fact part of the reason it would be useful is for people who don't know what to choose (which also means they wouldn't know what to put inconfig.json)... ie something this would be ideal (as a CLI select option):
e2-micro- Test project or demo, optimize for cost.n2d-standard-2- Standard baseline with room for growth (default).???????- Massive project. Optimize for performance.other- (Type in own...potentially will fail if incorrect or unknown but that's OK).
| name: api | ||
| port: | ||
| number: 80 | ||
| # rules: |
There was a problem hiding this comment.
One thing to keep in mind here is that the CLI currently I believe references these rules to create features branches (ie feature-api.foo.com etc)... I would like this to still work if possible.
There was a problem hiding this comment.
Also if not needed then this can just be removed?
There was a problem hiding this comment.
I believe the CLI requires an Ingress if you want to create feature branch and update the rules. I haven't tested this. The current default ( before this PR) is no ingress at all.
There was a problem hiding this comment.
I'm also looking into Gateways which seem to be the successor for Ingresses.
There was a problem hiding this comment.
oh that's interesting... Well I have some things I want to do with the CLI as well I guess I can make sure this is still working once this is merged and maybe sync with you on gateways 👍
|
@andrewplummer dont we need the root .env? |
|
@kaareal I recall either adding or removing it but I can't remember which one. I say apply my main rule: when in doubt get rid of it. If there's a reason to have it then we'll hit it again and whoever does is required to check in an empty file WITH A COMMENT about why to keep it, otherwise it's gone |
|
@andrewplummer i added it back now, it is indeed need, |
|
Commented in the other PR I think if we fix @bedrockio/config it can actually be removed |
