Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/django3 support #133

Closed
wants to merge 4 commits into from
Closed

Conversation

slei99
Copy link

@slei99 slei99 commented Dec 4, 2019

closes #132

@slei99
Copy link
Author

slei99 commented Dec 4, 2019

used devel as source and target. Not sure if this suits your release strategy.

@coveralls
Copy link

coveralls commented Dec 4, 2019

Coverage Status

Coverage remained the same at ?% when pulling b7dc4e4 on slei99:feature/django3-support into 86cb64b on bee-keeper:devel.

@slei99
Copy link
Author

slei99 commented Dec 4, 2019

sorry, contrib and travis newbie. I expected this to run on the source branch. I dont get why this runs on devel branch and not the feature branch, this is why it fails (missing space in tox. ini r**_**requirements.txt).
On a different note, the travis.yml looks confusing to me with the env and ìnclude config. Just tried to add a resonable test config for django 3

@Siecje
Copy link

Siecje commented Dec 10, 2019

Does django-invitiations support Python2? It seems like six can be removed entirely.

@gtwohig
Copy link
Contributor

gtwohig commented Dec 11, 2019

@slei99 if you change your base branch for the PR it will run against the master branch, It would also be good to test against python 3.8 now that that is out.

@bee-keeper seems sound to remove python2 support altogether (like #134 ) and also to include the Django3 testing from this PR

@MrCordeiro
Copy link
Contributor

Does django-invitiations support Python2? It seems like six can be removed entirely.

This makes total sense to me. With Python2 reaching the end of its support and Django 3 dropping the support altogether, it makes no sense to continue to support Python2 here either.

@bee-keeper bee-keeper closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants