Django 3.0 Compatibility Patch #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d be compatible with Django 3.0
…d be compatible with Django 3.0
Closed
…x module directly
|
This needs Or just remove |
Siecje
reviewed
Jan 30, 2020
…se for django.conf.urls/django.urls due to v1.11 limitations
…se for django.conf.urls/django.urls due to v1.11 limitations
…ango v!+. Pushing to test.
|
Issue found: |
Siecje
reviewed
Feb 5, 2020
Siecje
reviewed
Feb 5, 2020
Neglected to omit a line about working on a test branch. Removed.
bee-keeper
reviewed
Feb 5, 2020
bee-keeper
reviewed
Feb 5, 2020
bee-keeper
reviewed
Feb 5, 2020
bee-keeper
reviewed
Feb 5, 2020
Siecje
reviewed
Feb 5, 2020
…ort is being dropped
This comment has been minimized.
This comment has been minimized.
… url and replaced with re_path
…ango 3 is only compatible with Python 3.6 onward.
|
Travis seems to be stuck on the main repo's testing page, but on my fork, it looks like it passed! |
Siecje
approved these changes
Feb 5, 2020
bee-keeper
added a commit
that referenced
this pull request
Feb 7, 2020
* Django 3.0 Compatibility Patch (#136) * Added six module for python_2_unicode_compatible functionality. Should be compatible with Django 3.0 * Added six module for python_2_unicode_compatible functionality. Should be compatible with Django 3.0 * Patch; fixed utils.py by removing django.utils and referencing the six module directly * Added Six to install_requires arg in setup.py * Edits to tox. Errors with BackendAllauth may still be present * removed six; removed Python2 compatibility due to EOL/Code Freeze * removed six from install_requires * removed six from install_requires * Travis CI Integration * PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clause for django.conf.urls/django.urls due to v1.11 limitations * PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clause for django.conf.urls/django.urls due to v1.11 limitations * removing cache keys from travis to check against errors * pinned django-allauth version to 0.40.0 due to Dec update ditching Django v!+. Pushing to test. * Fixed malformed tox.ini setting for django-allauth version pin. * Update README Neglected to omit a line about working on a test branch. Removed. * Removed six + Django 1.11 support, per @bee-keeper's request * Removed django.conf.urls conditional import now that Django 1.11 support is being dropped * re-added conditional url imports at test_urls; removed six from requirements * fixed Django3 version error in tox.ini; removed conditional import of url and replaced with re_path * fixed tox error w/Python3.5 by removing Django v.3.0 from testing; Django 3 is only compatible with Python 3.6 onward. * continue to test against 1.x * tox Co-authored-by: Francis Secada <francis.secada@gmail.com>
ralphqq
pushed a commit
to kirubakaran/django-invitations
that referenced
this pull request
Aug 23, 2022
* Django 3.0 Compatibility Patch (jazzband#136) * Added six module for python_2_unicode_compatible functionality. Should be compatible with Django 3.0 * Added six module for python_2_unicode_compatible functionality. Should be compatible with Django 3.0 * Patch; fixed utils.py by removing django.utils and referencing the six module directly * Added Six to install_requires arg in setup.py * Edits to tox. Errors with BackendAllauth may still be present * removed six; removed Python2 compatibility due to EOL/Code Freeze * removed six from install_requires * removed six from install_requires * Travis CI Integration * PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clause for django.conf.urls/django.urls due to v1.11 limitations * PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clause for django.conf.urls/django.urls due to v1.11 limitations * removing cache keys from travis to check against errors * pinned django-allauth version to 0.40.0 due to Dec update ditching Django v!+. Pushing to test. * Fixed malformed tox.ini setting for django-allauth version pin. * Update README Neglected to omit a line about working on a test branch. Removed. * Removed six + Django 1.11 support, per @bee-keeper's request * Removed django.conf.urls conditional import now that Django 1.11 support is being dropped * re-added conditional url imports at test_urls; removed six from requirements * fixed Django3 version error in tox.ini; removed conditional import of url and replaced with re_path * fixed tox error w/Python3.5 by removing Django v.3.0 from testing; Django 3 is only compatible with Python 3.6 onward. * continue to test against 1.x * tox Co-authored-by: Francis Secada <francis.secada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Six module to replicate django-utils-encoding functionality.