Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3.0 Compatibility Patch #136

Merged
merged 21 commits into from Feb 7, 2020
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
63d5dab
Added six module for python_2_unicode_compatible functionality. Shoul…
fsecada01 Dec 26, 2019
4eff4c5
Added six module for python_2_unicode_compatible functionality. Shoul…
fsecada01 Dec 26, 2019
621ab15
Patch; fixed utils.py by removing django.utils and referencing the si…
fsecada01 Dec 26, 2019
18e5230
Added Six to install_requires arg in setup.py
fsecada01 Jan 22, 2020
1f12c71
Edits to tox. Errors with BackendAllauth may still be present
fsecada01 Jan 29, 2020
3f88f17
removed six; removed Python2 compatibility due to EOL/Code Freeze
fsecada01 Jan 30, 2020
73b8c5f
removed six from install_requires
fsecada01 Jan 31, 2020
92fbebd
removed six from install_requires
fsecada01 Jan 31, 2020
04516dc
Travis CI Integration
fsecada01 Jan 31, 2020
c9bf29f
PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clau…
fsecada01 Jan 31, 2020
d6a8716
PUSH ISSUE | MAKING SLIGHT CHANGE TO FIX COMMIT ISSUE try-except clau…
fsecada01 Jan 31, 2020
3d7e838
removing cache keys from travis to check against errors
fsecada01 Jan 31, 2020
006448e
pinned django-allauth version to 0.40.0 due to Dec update ditching Dj…
fsecada01 Feb 5, 2020
9ee7f6c
Fixed malformed tox.ini setting for django-allauth version pin.
fsecada01 Feb 5, 2020
56b5622
Update README
fsecada01 Feb 5, 2020
d00930a
Removed six + Django 1.11 support, per @bee-keeper's request
fsecada01 Feb 5, 2020
9da4832
Merge branch 'master' of https://github.com/fsecada01/django-invitations
fsecada01 Feb 5, 2020
6fe1f9d
Removed django.conf.urls conditional import now that Django 1.11 supp…
fsecada01 Feb 5, 2020
8ae9ada
re-added conditional url imports at test_urls; removed six from requi…
fsecada01 Feb 5, 2020
877e6f8
fixed Django3 version error in tox.ini; removed conditional import of…
fsecada01 Feb 5, 2020
e957eeb
fixed tox error w/Python3.5 by removing Django v.3.0 from testing; Dj…
fsecada01 Feb 5, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -7,6 +7,7 @@ dist/
.coverage/
django_invitations.egg-info/
.gitchangelog.rc
git-push.bat
.python-version
.coverage
/.idea/
Expand Down
2 changes: 2 additions & 0 deletions README.md
@@ -1,5 +1,7 @@
## Django-invitations - Generic invitations app

[WORKING ON PATCH FOR DJANGO 3.0 COMPATIBILITY]

fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
[![Build Status](https://travis-ci.org/bee-keeper/django-invitations.svg?branch=master)](https://travis-ci.org/bee-keeper/django-invitations)

[![Coverage Status](https://coveralls.io/repos/bee-keeper/django-invitations/badge.svg?branch=master&service=github)](https://coveralls.io/github/bee-keeper/django-invitations?branch=master)
Expand Down
2 changes: 1 addition & 1 deletion invitations/base_invitation.py
@@ -1,6 +1,6 @@
from django.conf import settings
from django.db import models
from django.utils.encoding import python_2_unicode_compatible
from six import python_2_unicode_compatible
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
from django.utils.translation import ugettext_lazy as _

from .managers import BaseInvitationManager
Expand Down
2 changes: 1 addition & 1 deletion invitations/models.py
Expand Up @@ -9,7 +9,7 @@
from django.db import models
from django.utils import timezone
from django.utils.crypto import get_random_string
from django.utils.encoding import python_2_unicode_compatible
from six import python_2_unicode_compatible
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
from django.utils.translation import ugettext_lazy as _

from . import signals
Expand Down
2 changes: 1 addition & 1 deletion invitations/utils.py
@@ -1,6 +1,6 @@
from django.apps import apps as django_apps
from django.core.exceptions import ImproperlyConfigured
from django.utils import six
import six
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved

from .app_settings import app_settings

Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Expand Up @@ -5,4 +5,5 @@ mock==3.0.5
pytest==5.2.2
pytest-django==3.6.0
pytest-cov==2.8.1
six==1.14.0
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
tox==3.14.0
5 changes: 4 additions & 1 deletion test_urls.py
@@ -1,4 +1,7 @@
from django.conf.urls import url, include
try:
from django.conf.urls import url, include
except ImportError:
from django.urls import url, include
from django.contrib import admin
from django.conf import settings

Expand Down
5 changes: 3 additions & 2 deletions tox.ini
Expand Up @@ -3,7 +3,7 @@ envlist =
py35-django{111,22}-backend{Basic,Allauth}
py36-django{111,22}-backend{Basic,Allauth}
py37-django{111,22}-backend{Basic,Allauth}
py38-django22-backend{Basic,Allauth}
py38-django{22,3}-backend{Basic,Allauth}
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
flake8

[pytest]
Expand All @@ -16,7 +16,8 @@ deps =
-r requirements.txt
django111: Django>=1.11.17,<2.0
django22: Django>=2.2.6
backendAllauth: django-allauth
django3: Django>=3
backendAllauth: django-allauth==0.40.0
fsecada01 marked this conversation as resolved.
Show resolved Hide resolved
commands =
python -V
backendBasic: py.test --cov-report term --cov=invitations --ignore=tests/allauth/ --ds=test_settings tests
Expand Down