Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make forms pluggable #84

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

fmarco
Copy link
Contributor

@fmarco fmarco commented Sep 29, 2017

Hello,
how about adding this changes ?
I'd like to use custom forms in some projects, what do you think?

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage decreased (-30.1%) to 61.712% when pulling 44fe718 on nephila:feature/pluggable_forms into 173524d on bee-keeper:master.

@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Coverage increased (+0.3%) to 92.117% when pulling 460d0e0 on nephila:feature/pluggable_forms into 173524d on bee-keeper:master.

@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Coverage increased (+0.2%) to 92.222% when pulling 1b21a4a on nephila:feature/pluggable_forms into 6f912a0 on bee-keeper:master.

@fmarco fmarco changed the title WIP: make forms pluggable make forms pluggable Nov 7, 2017
@bee-keeper
Copy link
Member

Sorry for the late reply @fmarco - could you give me a use case for this scenario? Thanks,

@fmarco
Copy link
Contributor Author

fmarco commented Dec 11, 2017

@bee-keeper Hi, no problem!
A use case could be the following: i'm customizing invitations and i'd like to have a proper control on view forms and admin form to make complex customizations in parallel with invitation model.

@yakky
Copy link
Member

yakky commented Jan 3, 2018

@bee-keeper do you have any feedback regarding our use case and implementation?

@maxnordlund
Copy link

I also would like to customize the admin forms, so this would be a great addition. However, this PR introduces a lot of unrelated changes and lacks a nice commit message. Would you mind cleaning it up so it can be merged @fmarco?

@fmarco
Copy link
Contributor Author

fmarco commented Jan 25, 2018

@maxnordlund Sure, i'll update this asap!

@maxnordlund
Copy link

Thank you

@fmarco
Copy link
Contributor Author

fmarco commented Jan 26, 2018

@maxnordlund done!

@maxnordlund
Copy link

Lovely, thanks

@bee-keeper
Copy link
Member

Ok thanks for this @fmarco - i did feel it was adding a bit of extra complexity but it's obviously useful to some people.

@bee-keeper bee-keeper merged commit 801a5e3 into jazzband:master Jan 30, 2018
@maxnordlund
Copy link

Would you mind cutting a new release with this @bee-keeper? So we can start using it for real :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants