Skip to content

Commit

Permalink
fix(security): upgrade jquery and bootstrap (#253)
Browse files Browse the repository at this point in the history
* Upgrade Bootstrap to v3.4.1

This fixes several [vulnerabilities][0] that are present in the currently used Bootstrap v3.7.1.

* Upgrade jQuery to v3.5.1

This fixes several [vulnerabilities][1] that are present in the currently used jQuery 3.2.1.

[0]: https://snyk.io/test/npm/bootstrap/3.3.7
[1]: https://snyk.io/test/npm/jquery/3.2.1
  • Loading branch information
Piccirello committed Oct 20, 2020
1 parent 2a268c3 commit 14b317b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 19 deletions.
8 changes: 4 additions & 4 deletions public/bootstrap.min.css

Large diffs are not rendered by default.

9 changes: 3 additions & 6 deletions public/bootstrap.min.js

Large diffs are not rendered by default.

9 changes: 2 additions & 7 deletions public/jquery.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/server/views/layout.hbs
Expand Up @@ -9,7 +9,7 @@

{{#if (useCdn)}}
<!-- Bootstrap core CSS -->
<link rel="stylesheet" href="https://cdn.jsdelivr.net/bootstrap/3.3.7/css/bootstrap.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/bootstrap/3.4.1/css/bootstrap.min.css">
<!-- JSON Viewer -->
<link rel="stylesheet" href="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.12.0/styles/default.min.css">
<script src="//cdnjs.cloudflare.com/ajax/libs/highlight.js/9.12.0/highlight.min.js"></script>
Expand Down Expand Up @@ -60,7 +60,7 @@

<input type="hidden" id="basePath" value="{{ basePath }}">
{{#if (useCdn)}}
<script type="text/javascript" src="//cdn.jsdelivr.net/g/jquery@3.2.1,bootstrap@3.3.7"></script>
<script type="text/javascript" src="//cdn.jsdelivr.net/combine/npm/jquery@3.5.1,npm/bootstrap@3.4.1/dist/js/bootstrap.min.js"></script>
{{else}}
<script type="text/javascript" src="{{ basePath }}/jquery.min.js"></script>
<script type="text/javascript" src="{{ basePath }}/bootstrap.min.js"></script>
Expand Down

1 comment on commit 14b317b

@bogdan
Copy link
Contributor

@bogdan bogdan commented on 14b317b Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piccirello the file https://cdn.jsdelivr.net/bootstrap/3.4.1/css/bootstrap.min.css doesn't exist:
image

Can you take a look?

Please sign in to comment.