-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node_redis with ioredis #16
Comments
I've had my eye on ioredis and will give this some consideration. When I started on this library it hadn't been released yet, but now it's looking quite nice. I'll get familiar with their API and give it a try sometime soon. |
I forked bee-queue to add ioredis and only two tests are failing(reconnection) |
Cool! Off the top of my head, I would expect those two tests to fail among all others; they're pretty specific to how node_redis deals with connections. I made an ioredis branch; feel free to open a PR to it and we can work from there. |
Actually there were a lot of tests failing and now there are only two: Queue "after each" hook and Queue Health Check reports a failed job My fork thelinuxlich@795a465 |
Moving forward with this in #21. I just want to leave a note here on cluster support in general; Because of the nature of Redis and its lists and (mostly) its Lua scripting, bee-queue won't exactly be able to offer true cluster support. It will work on Redis cluster deployments, but it will really just run everything on one Redis instance. Otherwise, the Lua scripts won't be able to access all the keys they need to in one place. Fortunately Redis cluster has a very nice way to do this:
but it should be clear that any one instance of bee-queue will still be running entirely on one instance of Redis. Of course, it will be possible to run multiple instances of bee-queue on multiple instances of Redis. |
+1 |
From #21
|
For redis 3 cluster support
The text was updated successfully, but these errors were encountered: