fix(queue): remove error event listener on close #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. good find |
shils
approved these changes
Apr 17, 2020
skeggse
force-pushed
the
remove-error-listener
branch
from
6f9c696
to
dc03d68
Compare
The error event listener is useful for catching errors from redis clients that aren't managed by the consumer of the library, but might cause problems for re-used connections.
skeggse
force-pushed
the
remove-error-listener
branch
from
dc03d68
to
618c6d4
Compare
beequeueci
pushed a commit
that referenced
this pull request
Nov 2, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-02) ### Features * implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d)) * support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d)) * **types:** add generics to type definitions ([a565d3d](a565d3d)) * **types:** add isRunning ([c488385](c488385)) * **types:** add ready handler ([32c4b1e](32c4b1e)) ### Bug Fixes * **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f)) * **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904)) * **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87)) * **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52)) * **types:** update createJob handler for consistency ([b71a993](b71a993)) * **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d)) * **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca)) * misc edge case fixes ([a2df983](a2df983)) * update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
beequeueci
pushed a commit
that referenced
this pull request
Nov 3, 2020
## [1.3.0](v1.2.3...v1.3.0) (2020-11-03) ### Features * implement Queue#saveAll feature ([#198](#198)) ([851f09d](851f09d)) * support custom strategies on a queue ([#134](#134)) ([926de9d](926de9d)) * **types:** add generics to type definitions ([a565d3d](a565d3d)) * **types:** add isRunning ([c488385](c488385)) * **types:** add ready handler ([32c4b1e](32c4b1e)) ### Bug Fixes * **backoff:** allow no delay arg when setting immediate strategy ([#154](#154)) ([6f1d62f](6f1d62f)) * **queue:** remove error event listener on close ([#231](#231)) ([36b4904](36b4904)) * **removeJob:** remove job from stored jobs ([#230](#230)) ([a8c9d87](a8c9d87)) * **types:** support progress events using arbitrary data ([#140](#140)) ([bc8aa52](bc8aa52)) * **types:** update createJob handler for consistency ([b71a993](b71a993)) * **types:** update redis option type ([#290](#290)) ([e80c51d](e80c51d)) * **types:** update type declaration ([#252](#252)) ([1dce7ca](1dce7ca)) * misc edge case fixes ([a2df983](a2df983)) * update typescript declarations and add documentation ([#187](#187)) ([cec1498](cec1498)), closes [#138](#138)
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error event listener is useful for catching errors from redis clients that aren't managed by the consumer of the library, but might cause problems for re-used connections.
Fixes #102 (per the extended discussion) cc @dylanjha.