Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only_text is set to True by default, updated tests #79

Merged
merged 3 commits into from
Jun 12, 2021
Merged

only_text is set to True by default, updated tests #79

merged 3 commits into from
Jun 12, 2021

Conversation

amadejpapez
Copy link
Collaborator

@amadejpapez amadejpapez commented Jun 12, 2021 •
edited

  • only_text is now by default True, so if a user wants API to scan a file/folder, they will need to set it to False
  • updated my recursion test - it worked really well, but it would always succeed
  • added a new test that is checking if all keys are present in each JSON object - it showed that 3 were missing plural_name

ghost
ghost reviewed Jun 12, 2021
View reviewed changes
tests/test_identifier.py Outdated Show resolved Hide resolved
@bee-san bee-san mentioned this pull request Jun 12, 2021
Merged
bee-san
bee-san approved these changes Jun 12, 2021
View reviewed changes
pywhat/what.py Show resolved Hide resolved
tests/test_identifier.py Show resolved Hide resolved
@bee-san bee-san merged commit 9b32630 into main Jun 12, 2021
@bee-san bee-san deleted the update-tests branch June 12, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bee-san bee-san bee-san approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amadejpapez @bee-san