Fix Deduplication Issues, Add Two More Special DB Endpoints #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deduplication issue that was reported by @tie by introducing two more of the sources (IMDB, TheMovieDB) to the "special one-to-many relations" club together with TheTVDB.
This will be a breaking change as the v2 endpoints will start rejecting any queries containing these sources.
These will instead be accessible via their own endpoints (
/api/v2/imdb,/api/v2/themoviedb).While this would be a breaking change that should be added to some
v3endpoints, I will not do this as fetching some IDs (anidb=11992) is broken right now, and only fixing it inv3would mean leaving the broken behavior inv2which is not acceptable.closes #789