Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using tap cmd directory. #11

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Move to using tap cmd directory. #11

merged 1 commit into from
Jan 13, 2017

Conversation

jsfaint
Copy link
Contributor

@jsfaint jsfaint commented Feb 5, 2016

With this modification brew-rmtree can be used without brew install
brew tap beeftornado/rmtree is enough :)

Just like brew-cask changed in Homebrew/homebrew-cask#15381

  • brew-rmtree.rb
    Move brew-rmtree.rb to cmd/brew-rmtree.rb.
  • Formula/brew-rmtree.rb
    Remove Formula, because we don't need it anymore.
  • README.md
    Modify the installation section.

With this modification brew-rmtree can be used without `brew install`
`brew tap beeftornado/rmtree` is enough :)

Just like brew-cask changed in Homebrew/homebrew-cask#15381

- brew-rmtree.rb
Move brew-rmtree.rb to cmd/brew-rmtree.rb.

- Formula/brew-rmtree.rb
Remove Formula, because we don't need it anymore.

- README.md
Modify the installation section.
@beeftornado beeftornado self-assigned this Feb 8, 2016
@beeftornado
Copy link
Owner

I'm not sure I completely understand how this works yet, but the concept sounds great. Let me test it out locally to get a feel for it and I'll get back to you. Thanks for the link to cask's PR

@jsfaint
Copy link
Contributor Author

jsfaint commented Feb 10, 2016

@bfontaine
Copy link

I came here to write the same PR 😄

@beeftornado In addition to the PATH, Homebrew checks the cmd directory of each tap to find commands. So any executable named brew-something (or brew-something.rb if it’s in Ruby) under cmd/ will be available as a command.

@tsparber
Copy link

brew doctor is now issuing a warning for the brew-rmtree.rb file in the taps root.

Warning: Found Ruby file outside beeftornado/rmtree tap formula directory
(/usr/local/Homebrew/Library/Taps/beeftornado/homebrew-rmtree/Formula):
  /usr/local/Homebrew/Library/Taps/beeftornado/homebrew-rmtree/brew-rmtree.rb

Using this PR fixes the warning too. Thank you for the script!

@sepehr
Copy link

sepehr commented Dec 27, 2016

Doctor's warning is getting annoying. That'd be great if you consider merging this. @beeftornado

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants