Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Better parenthesis support #604

Closed
xposure opened this issue Oct 16, 2020 · 3 comments
Closed

[Enhancement] Better parenthesis support #604

xposure opened this issue Oct 16, 2020 · 3 comments

Comments

@xposure
Copy link
Contributor

xposure commented Oct 16, 2020

I run in to this all the time, I will hit backspace then ( to bring up the tooltip for the method and this will add an addition parenthesis.

parenthesis

@xposure
Copy link
Contributor Author

xposure commented Oct 16, 2020

parenthesis2

An example of ) being eaten even though there aren't the correct number.

@bfiete
Copy link
Collaborator

bfiete commented Oct 16, 2020

Neither VS nor VSCode operate on "are there enough parentheses" as their metric. VS has different behavior depending on whether you manually move the cursor around after inserting parentheses which breaks out of the "paired parens" mode, it's kinda weird. VSCode will just ALWAYS delete the () pair when you delete the first (, which is probably a good solution.

@bfiete
Copy link
Collaborator

bfiete commented Oct 17, 2020

This has been revised at 743a8da
Also the feature where pressing ')' to move through a closing paren is different too. Basically there's a "recently inserted parentheses list" which is used for determining whether to insert a paren pair and to move through a closing paren. Manually moving the cursor clears that list.

@bfiete bfiete closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants