Better Go modules support for swagger document generation #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guhan121
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
i try it in GOPATH and GO MOD,it works perfect.
@de1acr0ix cool!
I am glad to contribute back. @guhan121 @askuy @wangle201210 could you help merge the change as well? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command
bee generate docsdoes not support Go modules well. This change utilizesgo/buildto resolve package paths. It supports whatevergo buildsupports automatically while reducing the code complexity.This PR also moves swagger related codes from
mainpackage toswaggergenpackage, makingmainpackage clearer.