always use server's locale to parse date #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing the date without time, it's always using UTC date, which is unexpected. If we want to use UTC date, it's recommend to set the server's timezone as UTC, and keep the code flexible.
astaxie
added a commit
that referenced
this pull request
Sep 4, 2015
always use server's locale to parse date
|
It will add more confusions when people need to support multi time zones in their applications if we use local machine's setting. |
|
@thanzen yea, it's trade-off. but in most case it just use the local timezone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing the date without time, it's always using UTC date, which is
unexpected. suppose we get '2015-09-02' from page, it's always parsed as '2015-09-02 00:00:00 UTC' but by default, what we expect is '2015-09-02 00:00:00' at local time zone.
And If we want to use UTC date throughout the system, it's recommend to set all
server's timezone as UTC including DB.