Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate route HTTP hook #4486

Merged
merged 1 commit into from Feb 10, 2021

Conversation

flycash
Copy link
Collaborator

@flycash flycash commented Feb 9, 2021

Now, beego will generate route based on controller's definition. But we already have bee too. So I think moving this function to bee tool is better.

Beego only need to public related functions.

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@flycash
Copy link
Collaborator Author

flycash commented Feb 9, 2021

beego/bee#762

@codecov-io
Copy link

Codecov Report

Merging #4486 (32b17c3) into develop (4861b1f) will increase coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4486      +/-   ##
===========================================
+ Coverage    53.18%   54.08%   +0.90%     
===========================================
  Files          236      235       -1     
  Lines        17608    17303     -305     
===========================================
- Hits          9365     9359       -6     
+ Misses        7305     7008     -297     
+ Partials       938      936       -2     
Impacted Files Coverage Δ
server/web/beego.go 0.00% <ø> (ø)
server/web/hooks.go 64.28% <ø> (+8.03%) ⬆️
server/web/config.go 54.32% <0.00%> (-2.47%) ⬇️
core/logs/file.go 65.82% <0.00%> (+1.00%) ⬆️
server/web/session/sess_mem.go 30.58% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4861b1f...32b17c3. Read the comment docs.

@jimashi
Copy link
Contributor

jimashi commented May 20, 2021

Now, beego will generate route based on controller's definition. But we already have bee too. So I think moving this function to bee tool is better.

Beego only need to public related functions.

I hope beego can keep annotations router based on controller' definition.Or split to beego plugin.So we use "go build" can compile success beego annotations router code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

注解路由需要编译两次 生成异常的路由文件commentsRouter__________Users_xxx_xxx.go
3 participants