support LifeCycleCallback #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DeepSource test cases can not pass. Pls take a look! |
|
why we need this feature? can you provide some scenarios? |
flycash
reviewed
Apr 26, 2022
jianzhiyao
reviewed
Apr 27, 2022
jianzhiyao
reviewed
Apr 27, 2022
jianzhiyao
reviewed
Apr 27, 2022
| @@ -76,6 +77,12 @@ func NewHttpServerWithCfg(cfg *Config) *HttpServer { | |||
| // MiddleWare function for http.Handler | |||
| type MiddleWare func(http.Handler) http.Handler | |||
|
|
|||
There was a problem hiding this comment.
Why there is no any implement of LifeCycleCallback ?
jianzhiyao
reviewed
Apr 27, 2022
|
lgtm |
|
SonarCloud Quality Gate failed.
|
robberphex
added a commit
to robberphex/example-beego-opensergo
that referenced
this pull request
Apr 29, 2022
robberphex
added a commit
to robberphex/example-beego-opensergo
that referenced
this pull request
Apr 29, 2022
robberphex
added a commit
to robberphex/example-beego-opensergo
that referenced
this pull request
Apr 29, 2022
|
这个合并，导致我无法开启graceful模式，开启后执行到ServeWithListener时，就不继续向下执行了..请问大家居然都没有遇到类似问题吗？ |
|
有最小可复现的例子吗？我来看看。 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's
net.http.Servercannot process in-transit requests when the server is shuting down, so graceful is set to the default Server implementation.net.http.Serveris used only if the user manually turn off (graceful=false).GetAllControllerInfo.GetAllControllerInfocan be used to debug and manage routing information conveniently in debugging and other extension mechanisms.LifeCycleCallback. Adding 'AfterStart' and 'BeforeShutdown' extension points in the Beego framework lifecycle to provide more extensibility.graceful=false），才使用net.http.Server。GetAllControllerInfo）。在调试或者其他扩展机制中，路由信息内省可以很方便的调试、管理路由信息。比如在应用启动时，列出所有的route信息，有助于业务开发者查看路由是否生效。
AfterStart和BeforeShutdown扩展点，能够提供更多的扩展性。比如在应用就绪后，将应用注册到consul等注册中心。