Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: web.controller saveToFile remove all temp file #5138

Merged
merged 2 commits into from Jan 16, 2023

Conversation

Stone-afk
Copy link
Contributor

upload remove all temp file

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #5138 (dff724b) into develop (1093610) will increase coverage by 0.09%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop    #5138      +/-   ##
===========================================
+ Coverage    54.83%   54.92%   +0.09%     
===========================================
  Files          250      250              
  Lines        21958    21961       +3     
===========================================
+ Hits         12041    12063      +22     
+ Misses        8960     8944      -16     
+ Partials       957      954       -3     
Impacted Files Coverage Δ
server/web/controller.go 30.83% <33.33%> (+3.95%) ⬆️
adapter/session/session.go 29.26% <0.00%> (-4.88%) ⬇️
server/web/session/redis/sess_redis.go 58.19% <0.00%> (-0.82%) ⬇️
server/web/router.go 71.90% <0.00%> (+0.76%) ⬆️
core/logs/file.go 69.64% <0.00%> (+2.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stone-afk Stone-afk changed the title WIP: feature upload remove all temp file bugfix: web.controller saveToFile remove all temp file remove all temp file Jan 15, 2023
@Stone-afk Stone-afk changed the title bugfix: web.controller saveToFile remove all temp file remove all temp file bugfix: web.controller saveToFile remove all temp file Jan 15, 2023
@flycash flycash merged commit 8d139b8 into beego:develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【temp file leak】if upload size > 32MB, a tmp file will be leave behind in /tmp directory.
3 participants