Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move noscript position and add imgStyle into fallback <img /> #66

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

elrumordelaluz
Copy link
Contributor

Hey @bluebill1049, first of all thanks for this cool library.

I found some issues regarding the <noscript> part and hope could be useful for every use case.

The point is that checking the cases where <noscript> should be available as fallback, since is rendered after the regular <img />, both as relative positioned elements, the fallback one remains outside the wrapper which has overflow: hidden styles. Swapping the order, in that case, the regular img (not needed) remains overflown.

The other point is to pass also imgStyles to the fallback img to have the same look and feel as the regular one.

Let me know in any case,

@bluebill1049
Copy link
Member

nice @elrumordelaluz thank you very much for the PR, I will a quick test and get it in tonight :)

@bluebill1049 bluebill1049 merged commit a18acea into beekai-oss:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants