Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MySQL to the BasicDatabaseClient abstract class implementation #1849

Closed
rathboma opened this issue Jan 5, 2024 · 0 comments · Fixed by #1861
Closed

Move MySQL to the BasicDatabaseClient abstract class implementation #1849

rathboma opened this issue Jan 5, 2024 · 0 comments · Fixed by #1861
Assignees
@azmy60
Labels
accepted 👍 enhancement New feature or request

Comments

@rathboma
Copy link
Collaborator

rathboma commented Jan 5, 2024 •
edited

This will help us simplify everything.

We should have two final classes:

  • MySqlClient
  • MariaDbClient extends MySqlClient

There are basically 0 differences between MariaDB and MySQL, but this is a good convention we should follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azmy60 azmy60

Labels
accepted 👍 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move mysql to BasicDatabaseClient beekeeper-studio/beekeeper-studio
2 participants
@rathboma @azmy60