Move mysql to BasicDatabaseClient
#1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Check if removed functions are used anywhere |
|
@not-night-but once you've approved it tag @azmy60 so he can merge it! |
azmy60
commented
Jan 22, 2024
not-night-but
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Looking good!! A couple things:
- Rather than branching on whether or not it is mysql, we should just override the function in the child
- Functions that need access to instance members, and don't need to be statically accessed can just be private/protected helper functions.
Fantastic job as always. Common Azmy W
wmontgomery
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1849