Should trigger initial filters on first time load and other bugs #1706
Conversation
| @@ -224,7 +224,7 @@ import data_converter from "../../mixins/data_converter"; | |||
| import DataMutators, { escapeHtml } from '../../mixins/data_mutators' | |||
| import { FkLinkMixin } from '@/mixins/fk_click' | |||
| import Statusbar from '../common/StatusBar.vue' | |||
| import RowFilterBuilder from './RowFilterBuilder.vue' | |||
| import RowFilterBuilder, { normalizeFilters } from './RowFilterBuilder.vue' | |||
There was a problem hiding this comment.
You should move this function somewhere else, Vue files should really only contain the vue component. Maybe utils?
| @@ -924,6 +924,7 @@ export default Vue.extend({ | |||
| this.rawTableKeys = await this.connection.getTableKeys(this.table.name, this.table.schema) | |||
| const rawPrimaryKeys = await this.connection.getPrimaryKeys(this.table.name, this.table.schema); | |||
| this.primaryKeys = rawPrimaryKeys.map((key) => key.columnName); | |||
| this.filters = normalizeFilters(this.initialFilters || []) | |||
There was a problem hiding this comment.
Did we need to do this previously? I don't think we did, shouldn't initialFilter in the tabulator constructor do this?
There was a problem hiding this comment.
Actually, we had this before but in a little different way. this.filter was used in filterForTabulator() which then used in many different parts including the tabulator dataFetch.
In this case, this.filters is empty and was not assigned with the initialFilters initially, which is why when we're fetching the data in dataFetch(), the data is not filtered at all.
Edit:
Btw, I removed the filterForTabulator() so we can keep the logic for building filters just in <RowFilterBuilder />
There was a problem hiding this comment.
I accidentally removed that part and didn't know it's actually gonna affect the fk click. 🤦
azmy60
changed the title
Bugs:
initialFiltersinitiallyid=>equals=>1