minor fix: bool should not be empty when there is not null constraint

[azmy60]

Prior to this, users were allowed to input empty value (empty string) to non-nullable boolean. Steps to reproduce:

1. In sqlite, create a table containing nullable bool and non nullable bool

CREATE TABLE
  `table_with_bool` (
    `id` integer not null primary key autoincrement,
    `flag1` bool not null,
    `flag2` bool null
  );
insert into `table_with_bool` (`flag1`, `flag2`, `id`) values ('0', NULL, '1');

2. Open the table, click non nullable bool cell, and then click away to cancel the edit.

3. Now you can see the cell is (EMPTY) and can be applied (Does not give an error!).

(EMPTY) here is not a null value, which is why there is no constraint error. Also it's sqlite... yknow...

This PR will:

• fix that
• add nullable option to nullable bool column

BEFORE (unable to assign null and get back to original value 😡):

AFTER (:innocent:):

[rathboma]

Shouldn't labels here be true and false? For non-Sqlite boolean columns especially.

[rathboma]

Also, for non-sqlite, shouldn't the values be 'true' and 'false' also?

[rathboma]

Oh, sorry I missed the dropdown will show false/true section below.

Question though -- do 0 and 1 map to boolean data types in all the other databases? Maybe that needs a test to confirm

[azmy60]

Oh I thought boolean is only in sqlite. 0 and 1 do not map to boolean types in postgres. With that I think it's simpler to use false / true like before. It's easy to switch. Give me a second.

[azmy60]

Actually, it needs some generic mapping like mysqlDialect.booleanValues: { "true": BigInt(1), "false": "BigInt(0)" }, and then do this to each dialect.

[azmy60]

The only thing that changes here is in sqlite, we're showing 0 and 1 in dropdown, instead of false and true. That's probably the simplest solution we could have. Is that ok?

The problem with sqlite is that boolean is represented as 0 and 1, and when using false and true as the dropdown options, it doesn't match up, which then shows that (empty) value.

We still can use the false and true as values for sqlite though if you want. I just need some time to wire up the good solution to that.

[rathboma]

Nice work!