Fix: Leave aliases to be unquoted in autocomplete #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-night-but
previously requested changes
Oct 14, 2023
There was a problem hiding this comment.
@azmy60 Nice! Glad we got this one figured out.
Code looks good, but do you think you could add some regression tests for this?
|
Oh yeah, forgot that one. Let me see if I can do it. |
azmy60
changed the title
…per-studio into fix/quoted-alias
rathboma
reviewed
Nov 8, 2023
|
Ok for you to merge, but if also a problem in other dialects, they'll need sorting also. eg SQL Server has schemas + tables also |
rathboma
approved these changes
Nov 26, 2023
|
Redshift needs the autoquote too so that's added. Merging now :) Everything else looks good! |
|
hmm.. I can't merge it somehow 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing CodeMirror outside of bks just little bit. It turns out that this behavior was not from the CodeMirror itself😅 .
Fixes point 2 in #1721